Use a lightweight bind implementation when no placeholders are given #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea! LGTM, thanks. |
| @@ -84,27 +82,27 @@ namespace hpx { namespace util | |||
| static HPX_FORCEINLINE | |||
| type call(T& t, Us&& /*unbound*/) | |||
| { | |||
| return std::move(t); | |||
| return std::forward<T>(t); | |||
There was a problem hiding this comment.
Agustin, why is std::forward used here (when t is not forwarding reference)?
There was a problem hiding this comment.
T is a forwarding reference in this context, it will be an lvalue-reference when the bound argument is a reference_wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.