Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent usage of CMake try_run on crosscompiling #6496

Closed
wants to merge 1 commit into from

Conversation

Pansysk75
Copy link
Member

No description provided.

@Pansysk75 Pansysk75 requested a review from hkaiser as a code owner May 27, 2024 18:56
@Pansysk75 Pansysk75 force-pushed the cacheline-crosscompiling-fix branch from f9a9899 to 7b912af Compare May 27, 2024 19:05
@hkaiser
Copy link
Member

hkaiser commented May 27, 2024

I added a similar fix to the release branch only (see: a7af887) assuming that we will merge that branch to master shortly. I should have gone through a PR instead - sorry for that.

@hkaiser hkaiser added this to the 1.11.0 milestone May 27, 2024
@Pansysk75
Copy link
Member Author

I added a similar fix to the release branch only (see: a7af887) assuming that we will merge that branch to master shortly. I should have gone through a PR instead - sorry for that.

Ah, missed that, no worries. Feel free to close this PR

@hkaiser hkaiser closed this May 27, 2024
@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)=(=)

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-05-27T19:05:10+00:00
HPX Commitd27ac2ea6f5689
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Clusternamerostamrostam
Datetime2024-03-18T09:18:04.949759-05:002024-05-27T16:59:58.473977-05:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch(=)

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-05-27T19:05:10+00:00
HPX Commitd27ac2ea6f5689
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Clusternamerostamrostam
Datetime2024-03-18T09:19:53.062988-05:002024-05-27T17:01:44.149520-05:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)-=

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-05-27T19:05:10+00:00
HPX Commitd27ac2ea6f5689
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Clusternamerostamrostam
Datetime2024-03-18T09:20:13.002391-05:002024-05-27T17:02:00.739122-05:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.12%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0ca711f) 222028 188803 85.04%
Head commit (7b912af) 191067 (-30961) 162712 (-26091) 85.16% (+0.12%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6496) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants