-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom FETCHCONTENT_BASE_DIR bug fix #6513
Conversation
Can one of the admins verify this patch? |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Fixing custom output directory error
Also, please address the cmake-format issue reported (see https://gist.github.com/hkaiser/debb4ce2e5cf64722db0f49c90cee01a) |
Since cmake does not provide a single variable for all occasions, I decided to create a condition. If a special path was specified, then use it, otherwise, what was initially specified in the code (default path). |
Compatibility of hwloc with the install command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Congratulations, your first PR to the HPX repository has just been merged! As a 'thank you' we offer a free STE||AR-Group t-shirt to all of our first-time contributors. If you are interested in receiving one, please get back to me directly so we can set up the delivery. |
Fixes a bug related to incorrect paths when automatically loading
hwloc
.If the path for downloaded projects is
FETCHCONTENT_BASE_DIR
has been changed, then the existing
cmake
script points to a non-existent folder, sincehwloc
will be loaded to another location.