-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross product primitive implemented #99
Conversation
8d67848
to
ab55dcc
Compare
The NumPy docs say (see https://docs.scipy.org/doc/numpy-1.13.0/reference/generated/numpy.cross.html):
IOW, we should add support for a cross product of 2 dimensional arrays as well. |
d1ff86f
to
84ae384
Compare
After experimenting with NumPy a bit I found these differences with my current implementation that I have to address:
np.cross([1, 2], [[4, 5], [7, 8], [1, 2]])
np.cross([1, 2, 3], [[4, 5], [7, 8], [1, 2]])
|
blaze::DynamicMatrix<double> v2{{4.0, 5.0, 6.0}, {1.0, 2.0, 3.0}}; | ||
|
||
blaze::DynamicMatrix<double> expected{{-3.0, 6.0, -3.0}, {3.0, -6.0, 3.0}}; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These three tests above don't look complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank you!
Part of issue #2