Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up the USB IRQ handler #17

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Conversation

gorlik
Copy link
Contributor

@gorlik gorlik commented Apr 14, 2021

Avoid reading ISTR multiple times which is quite slow on L0 MCUs
Change follows the same pattern in PCD_EP_ISR_Handler. Cache the value in wIstr and do repeated checks on the variable.

IMPORTANT INFORMATION

Contributor License Agreement (CLA)

  • The Pull Request feature will be considered by STMicroelectronics after the signature of a Contributor License Agreement (CLA) by the submitter.
  • If you did not sign such agreement, please follow the steps mentioned in the CONTRIBUTING.md file.

Avoid reading ISTR multiple times which is quite slow on L0 MCUs
Change follows the same pattern in PCD_EP_ISR_Handler. Cache the value in wIstr and do repeated checks on the variable.
@ALABSTM ALABSTM self-assigned this Apr 22, 2021
@ALABSTM ALABSTM added hal HAL-LL driver-related issue or pull-request. usb USB-related (host or device) issue or pull-request enhancement New feature or request labels Apr 26, 2021
@ALABSTM
Copy link
Contributor

ALABSTM commented Apr 26, 2021

Hi @gorlik,

Thank you for this proposal. It will be logged into our internal database and submitted to our development teams. I will keep you informed.

With regards,

@ALABSTM ALABSTM added the internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system label Apr 26, 2021
@ALABSTM
Copy link
Contributor

ALABSTM commented Apr 26, 2021

ST Internal Reference: 105754

Copy link
Contributor

@ALABSTM ALABSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution @gorlik.

@ALABSTM ALABSTM merged commit 00db5bd into STMicroelectronics:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hal HAL-LL driver-related issue or pull-request. internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system usb USB-related (host or device) issue or pull-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants