Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Documenter as a dependency #163

Merged
merged 2 commits into from
Jul 4, 2020
Merged

Drop Documenter as a dependency #163

merged 2 commits into from
Jul 4, 2020

Conversation

Nosferican
Copy link
Contributor

@Nosferican Nosferican commented Jul 3, 2020 •
edited
Loading

Closes #162.

@Nosferican
Update Project.toml
c93dfea
@Nosferican
Fix Documenter
1d539f0 
It seems it is not used in the package or the tests. It seems it is only used for the docs so I have made those adjustments.
@coveralls
Copy link

coveralls commented Jul 3, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 475

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.822%
Totals Coverage Status
Change from base Build 471: 0.0%
Covered Lines: 1468
Relevant Lines: 1962
💛 - Coveralls

@Nosferican Nosferican marked this pull request as ready for review July 3, 2020 17:49
@Nosferican Nosferican changed the title Move Documenter to Extras Drop Documenter as a dependency Jul 3, 2020
@maximerischard
Copy link
Contributor

This makes a lot of sense, thank you.

@maximerischard maximerischard merged commit 0a3f3e1 into STOR-i:master Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documenter compat issue
3 participants
@Nosferican @coveralls @maximerischard