localization fixes #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerblecher
requested changes
Nov 17, 2020
Comment on lines
+37
to
+39
| "UNEXPECTED_ERROR": "ארעה שגיאה בלתי צפויה!", | ||
| "WRONG_CREDENTIALS": "אחד הפרטים שהכנסת שגוי!", | ||
| "UNKNOWN_ERROR": "ארעה שגיאה לא ידועה.", |
There was a problem hiding this comment.
RemoveUNKNOWN_ERROR translation(Keep UNEXPECTED_ERROR)
Comment on lines
+37
to
+39
| "UNEXPECTED_ERROR": "An unexpected error has occurred!", | ||
| "WRONG_CREDENTIALS": "One of the credentials is incorrect!", | ||
| "UNKNOWN_ERROR": "An unknown error has occurred.", |
There was a problem hiding this comment.
RemoveUNKNOWN_ERROR translation(Keep UNEXPECTED_ERROR)
Comment on lines
+109
to
+113
| // ---------------------------------------------------------------------------------------------------------------- | ||
| // --TODO: is this more readable than 'CONTENT_REQUEST_SUCCESSFULLY'.tr() -- | ||
| // --To auto generate code completion we need to use command: -- | ||
| // --flutter pub run easy_localization:generate -f keys -o locale_keys.g.dart --source-dir ./assets/translations/-- | ||
| // ---------------------------------------------------------------------------------------------------------------- |
| _identitySubject.sink.addError( | ||
| NetworkError(res.statusCode, 'An unknown error has occurred.')); | ||
| _identitySubject.sink | ||
| .addError(NetworkError(res.statusCode, 'UNKNOWN_ERROR'.tr())); |
There was a problem hiding this comment.
replace with UNEXPECTED_ERROR
| season.episodes.forEach((element) { | ||
| if (element.status == MediaContentStatus.MISSING) | ||
| missingEpisodes.add(element.number); | ||
| }); | ||
| } | ||
|
|
||
| Widget get header => Text("Season ${season.number}"); | ||
| Widget get header => Text('${'SEASON'.tr()} ${season.number}'); |
| _identitySubject.sink.addError(NetworkError( | ||
| res.statusCode, 'One of the credentials is incorrect!')); | ||
| _identitySubject.sink | ||
| .addError(NetworkError(res.statusCode, 'WRONG_CREDENTIALS'.tr())); |
| @@ -99,7 +100,7 @@ class _SeriesRequestSelectionState extends State<SeriesRequestPage> { | |||
| height: 30, | |||
| child: FlatButton( | |||
| child: Text( | |||
| 'Select All', | |||
| 'SELECT_ALL'.tr(), | |||
| @@ -115,7 +116,7 @@ class _SeriesRequestSelectionState extends State<SeriesRequestPage> { | |||
| ) | |||
| : FlatButton( | |||
| child: Text( | |||
| 'Submit', | |||
| 'SUBMIT'.tr(), | |||
| @@ -21,7 +21,8 @@ class _SeasonExpansionTileState extends State<SeasonExpansionTile> { | |||
| return ListTile( | |||
| title: widget.item.header, | |||
| subtitle: (widget.episodeRequests.isNotEmpty) | |||
| ? Text("${widget.episodeRequests.length} episodes selected") | |||
| ? Text( | |||
| '${widget.episodeRequests.length} ${'EPISODES_SELECTED'.tr()}') | |||
| }); | ||
| }, | ||
| ) | ||
| child: Text('CANCEL'.tr()), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.