Fix flow error due to incorrectly set defaultProps #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interestingly, I'm not getting this Flow error, but it should show up. Edit: Getting it when included in other packages... investigating. |
|
Surfaced the error in 0e38ea0 and used that as an opportunity to fix up the props defs. |
n1ghtmare
pushed a commit
to n1ghtmare/react-grid-layout
that referenced
this pull request
Feb 26, 2020
This made the bug described in react-grid-layout#1137/react-grid-layout#1138 visible by adding typing to examples, ensuring that we're using RGL and RRGL as well as the WidthProvider HOC in actual code, so Flow covers it completely.
|
This actually creates a behavioral difference as |
STRML
added a commit
that referenced
this pull request
Sep 3, 2020
This inadvertently caused containerPadding to default to [0, 0] on default ResponsiveReactGridLayouts, not to the value of `margin`. This restores the previous behavior and fixes types. Prettier seems to have a bug and attempts to line-wrap the typedef in ResponsiveReactGridLayout#L59, breaking the type, so I added an ignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1137
a simple fix for the issue i created.
sets the
containerPaddingwithindefaultPropsto the expected value.