Pde/multiple optimizely #1410
Pde/multiple optimizely #1410
Conversation
…stances, generate adapters on i
|
missing tests and documentation |
alextremp
requested review from
midudev,
kikoruiz,
rmoralp and
sui-bot
as code owners
packages/sui-pde/README.md
Outdated
| ### Multiple Optimizely Adapters | ||
|
|
||
| Meant to exist if you need more than one decision taking optimizely sdk. | ||
| Integration with segment will only work for the first one so it will be necesary to configure segment so it forwards the events to the other optimizely destinations. |
There was a problem hiding this comment.
What we should do in Segment config to enable it?
There was a problem hiding this comment.
updated with more specific info
| * @param {object} optimizely test purposes only, optimizely sdk | ||
| * @param {object} param.options datafile options https://docs.developers.optimizely.com/full-stack/docs/initialize-sdk-javascript-node | ||
| * @param {object} param.optimizely test purposes only, optimizely sdk | ||
| * @param {function} param.eventDispatcher https://docs.developers.optimizely.com/full-stack/docs/initialize-sdk-javascript-node |
There was a problem hiding this comment.
| * @param {function} param.eventDispatcher https://docs.developers.optimizely.com/full-stack/docs/initialize-sdk-javascript-node | |
| * @param {function} param.eventDispatcher https://docs.developers.optimizely.com/full-stack/docs/configure-event-dispatcher-javascript-node |
| * @return {{variation: string}} | ||
| */ | ||
| export default function useExperiment({ | ||
| experimentName, | ||
| attributes, | ||
| trackExperimentViewed, | ||
| queryString // for test purposes only | ||
| queryString, | ||
| adapterId |
There was a problem hiding this comment.
Is adapterId required?
Could you add some examples about useFeature and useExperiment when using multiple adapters?
| #adapters = {} | ||
|
|
||
| constructor(optimizelyAdapters) { | ||
| defaultAdapterId = Object.keys(optimizelyAdapters)[0] // first adapter will be the defaultAdapter |
There was a problem hiding this comment.
If optimizelyAdapters object keys are adapterId's, why not find for default one first?
There was a problem hiding this comment.
adapterIds are not required to have a default key, you could pass:
const multiple = new MultipleOptimizelyAdapter({
adapter1: firstAdapter,
adapter2: secondAdapter,
})
In this case, the defaultAdapterId would be adapter1 so when using PDE without passing any adapterId in the calls, adapter1 will be used.
Trying to make it easier to have two optimizely client instances at the same time