Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access aggregate ID config option #171

Merged
merged 3 commits into from
May 31, 2021

Conversation

indy-independence
Copy link
Member

Add API to allow configuring of "aggregate_id" to specify LACP configurations on access ports

@indy-independence
Copy link
Member Author

Fixes issue #169

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #171 (c25a777) into develop (c906d0a) will increase coverage by 0.45%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #171      +/-   ##
===========================================
+ Coverage    58.70%   59.16%   +0.45%     
===========================================
  Files           59       60       +1     
  Lines         5974     5992      +18     
===========================================
+ Hits          3507     3545      +38     
+ Misses        2467     2447      -20     
Impacted Files Coverage Δ
src/cnaas_nms/api/interface.py 79.33% <85.71%> (+11.86%) ⬆️
src/cnaas_nms/tools/jinja_filters.py 14.70% <0.00%> (ø)
src/cnaas_nms/confpush/nornir_helper.py 100.00% <0.00%> (+44.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c906d0a...c25a777. Read the comment docs.

@indy-independence indy-independence marked this pull request as ready for review May 31, 2021 11:51
@indy-independence indy-independence merged commit 02c3e2c into develop May 31, 2021
@indy-independence indy-independence deleted the feature.access_aggregate_id branch May 31, 2021 11:51
@indy-independence indy-independence added this to the v1.3.0 milestone Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant