Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust 1.61.0 support #15

Closed
jelmd opened this issue Feb 1, 2023 · 12 comments
Closed

rust 1.61.0 support #15

jelmd opened this issue Feb 1, 2023 · 12 comments

Comments

@jelmd
Copy link

jelmd commented Feb 1, 2023

Since on Ubuntu LTS 20.04 (focal) - and probably on its derivations, too - rust 1.61.0 is the only supported version, it would be nice to get the fuc compiled there as well. Right now it fails with something like "blabla requires rustc 1.63.0" or even 1.64.0 ...

@SUPERCILEX
Copy link
Owner

Unfortunately I need a number of nightly features, so no stable version of the compiler will work. I don't expect this to change anytime soon. You'll want to use the prebuilt binaries or rustup: https://doc.rust-lang.org/cargo/getting-started/installation.html

@jelmd
Copy link
Author

jelmd commented Feb 1, 2023

Hmmm, ok. Idea was to provide it on our cluster nodes. But there only packages are allowed and I build the missing ones with supported compilers, only. Anyway, if users think they need it, they can build, or download, or bench on their own risk ... ;-)

@jelmd
Copy link
Author

jelmd commented Feb 1, 2023

BTW: x86_64-unknown-linux-gnu binaries do not work as well, because they are linked against GNU libc > 2.31.

@SUPERCILEX
Copy link
Owner

Hmmm, you'll probably need to use the *-musl variants then (as they're statically linked). 20.04 is pretty old at this point.

@andreasstieger
Copy link
Contributor

I checked and the nightly features you are using are not in 1.68 either. Your choice, but even rolling distributions would appreciate if you found a way to target current rust stable.

SUPERCILEX added a commit that referenced this issue Mar 26, 2023
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Copy link
Owner

I really don't want to have to copy all of once_cell, but I dropped some features that should be implemented with other nightly features anyway. So basically this is pending once_cell stabilization.

@andreasstieger
Copy link
Contributor

andreasstieger commented Mar 27, 2023 via email

@SUPERCILEX
Copy link
Owner

Lemme first see if I can get once_cell moving again: it finished its fcp back in January, so it's a little surprising that it hasn't been merged yet. Otherwise, are people building from master or tags? I could potentially just apply a patch before tagging that has stable support and keep master on nightly.

@andreasstieger
Copy link
Contributor

Distros can build from any git reference including tags, and any combination of patches on top, including non-contiguous series. I'll volunteer my openSUSE package for fast feedback.

SUPERCILEX added a commit that referenced this issue Mar 27, 2023
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Copy link
Owner

Hmmm, ok. I don't want to make any guarantees that I won't return to requiring nightly, but it's currently trival to support building the binaries with stable. cargo test still requires nightly, but that isn't a problem I hope/assume.

Triggered a release: https://github.com/SUPERCILEX/fuc/actions/runs/4536253663
Patch applied in 1.1.7: e2285aa

@SUPERCILEX
Copy link
Owner

As a sanity check, it'd be helpful if someone could cargo install rmz cpz on stable rust.

@andreasstieger
Copy link
Contributor

Looks good with (at least) rust 1.68, package works. For cargo install rmz cpz see separate issue referred below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants