Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random institution name used if IdP is not found in metadata list #614

Closed
baszoetekouw opened this issue Apr 3, 2023 · 2 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@baszoetekouw
Copy link
Member

When loggin in with an unknown IdP (for example, SURFnet acc on test), SBS shows a random idP name:

image

Maybe just show "unknown institution" in this case.

@oharsta
Copy link
Collaborator

oharsta commented Apr 3, 2023

SRAM does not show a random IdP, but shows the DisplayName from the https://metadata.surfconext.nl/edugain-downstream.xml metadata where the Scope value equals the user.schac_home_organisation. However when the user is provisioned in the /proxy_authz we don't receive the schac_home_organisation and it is set to None.

Due to a bug / feature in the idp_metadata_parser the not nl language is used as the en language. In the metadata stream there is a Croatian DisplayName (<mdui:DisplayName xml:lang="hr">AAI@EduHr sustav jedinstvene autentikacije korisnika</mdui:DisplayName>) which is picked up as the en language and is tied to 237 Scope / schac_home_organisation values. Due to another feature / bug one of the values is None and this equals the schac_home_organisation of the user. Solution is to add a schac_home_organisation value to the dict which eduTeams sends to the /proxy_authz endpoint (and do not store None scope values in the metadata). Related to #577.

@baszoetekouw
Copy link
Member Author

This is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants