Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #219, #234 and #237 #238

Closed
wants to merge 12 commits into from

Conversation

dimtsap
Copy link
Contributor

@dimtsap dimtsap commented May 9, 2024

@connor-krill Can you please verify that the spectral tests produce the correct results with your updated version?

@dimtsap dimtsap requested a review from connor-krill May 9, 2024 21:22
Copy link
Contributor

@connor-krill connor-krill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spectral representation tests were failing. They should be reverted to their previous values. The Stochastic Process module is being worked on in the branchfeature/srm_phase_angle

connor-krill
connor-krill previously approved these changes May 10, 2024
Copy link
Contributor

@connor-krill connor-krill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing SRM tests were resolved, everything else lgtm!

Copy link

sonarcloud bot commented May 20, 2024

@dimtsap dimtsap closed this May 20, 2024
@dimtsap dimtsap deleted the feature/update-packages-to-latest branch May 20, 2024 19:43
@dimtsap dimtsap restored the feature/update-packages-to-latest branch May 22, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants