-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to google-cloud-compute package #376
base: main
Are you sure you want to change the base?
Conversation
Do not merge. Pending packages and inclusion of |
Drop requirement on discovery API
package/python3-img-proof.spec
Outdated
@@ -60,7 +60,7 @@ Requires: python3-azure-mgmt-network | |||
Requires: python3-azure-mgmt-resource | |||
Requires: python3-boto3 | |||
Requires: python3-click | |||
Requires: python3-google-api-python-client | |||
Requires: python3-google-cloud-compute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going to want to change the packaging to the same scheme as ec2imgutils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this builds for TW which wouldn't necessarily be python3.11 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Requires:
directives should just be python-*
now. With the assumption that the dependencies use the macros correctly. Then when this code gets build for python311 for example it will automatically pull the python311 dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, was looking at an old version of ec2imgutils.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
Requires:
directives should just bepython-*
now.
rly? source package should be python-*
but any package with python3 should provide python3-*
and python{ver}-*
.. python-*
in non source context is reserved for python2 packages
Drop requirement on discovery API