Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to google-cloud-compute package #376

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Migrate to google-cloud-compute package #376

wants to merge 2 commits into from

Conversation

smarlowucf
Copy link
Collaborator

Drop requirement on discovery API

@smarlowucf
Copy link
Collaborator Author

Do not merge. Pending packages and inclusion of confidential_instance_type in v1 of API.

Drop requirement on discovery API
@@ -60,7 +60,7 @@ Requires: python3-azure-mgmt-network
Requires: python3-azure-mgmt-resource
Requires: python3-boto3
Requires: python3-click
Requires: python3-google-api-python-client
Requires: python3-google-cloud-compute
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to want to change the packaging to the same scheme as ec2imgutils

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this builds for TW which wouldn't necessarily be python3.11 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Requires: directives should just be python-* now. With the assumption that the dependencies use the macros correctly. Then when this code gets build for python311 for example it will automatically pull the python311 dependencies.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, was looking at an old version of ec2imgutils.

Copy link

@mimi1vx mimi1vx May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Requires: directives should just be python-* now.

rly? source package should be python-* but any package with python3 should provide python3-* and python{ver}-* .. python-* in non source context is reserved for python2 packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants