Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dmcrypt & Bluestore #130

Closed
wants to merge 4 commits into from
Closed

Dmcrypt & Bluestore #130

wants to merge 4 commits into from

Conversation

jschmid1
Copy link
Contributor

@jschmid1 jschmid1 commented Mar 7, 2017

Enabling Dmcrypt and Bluestore

Signed-off-by: Joshua Schmid jschmid@suse.de

@BlaineEXE
Copy link
Contributor

When contributing a new feature to a repo, the commits should be organized such that it looks like things were done perfectly the first time, only breaking a pull into multiple commits when there are multiple distinct steps to enabling the feature. With this pull request, I'd expect to see all 4 of these commits squashed together into one commit. Additionally, the commit should have an imperative subject and should note in the commit body more about the design of the commit patch.

I try to follow these guidelines: https://chris.beams.io/posts/git-commit/

@jschmid1
Copy link
Contributor Author

jschmid1 commented Mar 28, 2017

I should've updated the PR earlier.

It's kinda on hold until we settled on a solution that we want to go with.

see @rjfd proposal for configuration formatting etc.

but thanks for pointing to guidlines!

@swiftgist
Copy link
Contributor

In general, an sls file should have more lines about the states than Jinja logic. I think a good bit of this fits nicely into a salt module to correctly construct the command.

Joshua Schmid added 4 commits April 26, 2017 18:49
Signed-off-by: Joshua Schmid <jschmid@suse.de>
Signed-off-by: Joshua Schmid <jschmid@suse.de>
Signed-off-by: Joshua Schmid <jschmid@suse.de>
Signed-off-by: Joshua Schmid <jschmid@suse.de>
@swiftgist
Copy link
Contributor

Discussion continues in #62. Work progress in https://github.com/SUSE/DeepSea/tree/wip-osd

@swiftgist swiftgist closed this May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants