Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

signup: perform checks on the client side #861

Open
2 tasks
mssola opened this issue May 6, 2016 · 4 comments
Open
2 tasks

signup: perform checks on the client side #861

mssola opened this issue May 6, 2016 · 4 comments

Comments

@mssola
Copy link
Collaborator

mssola commented May 6, 2016

It's a bit cumbersome to allow users to enter whatever they want in the signup form, just to tell them they did it wrong afterwards. We should perform some client side checks (e.g. format of the username, that both the confirmation and the password match, etc.), and disallow the creation of the user if the requirements are not met.

Update

  • Provide a /validate API endpoint for this resource.
  • Add the necessary client-side work.
@mssola mssola added this to the Tentative for 2.1 milestone May 6, 2016
@flavio
Copy link
Member

flavio commented May 9, 2016

Maybe this can be addressed during the GSoC?

@alexis19apl
Copy link

Hello good night mssola;

One of the full time engineer from Suse let me to this project to help and also learn, knowing how i reach this project want to know how can i contribute with you guys?

@krishnak9
Copy link

Should we use the client_side_validation gem for this purpose or have a custom implementation for that. I am interested in doing this fix. Please help me in this regard. And what do we mean by the format of username exactly? I mean is there any predefined format for that.

@mssola
Copy link
Collaborator Author

mssola commented Mar 14, 2017

@krishnak9 this gem looks unnecessary. That being said, I'm not entirely sure what would be the best way to handle this. You could either do some validation entirely on the client side, or add a method on the registrations controller that the client code can call.

@mssola mssola modified the milestones: Tentative: others, Release 2.3 Aug 2, 2017
@mssola mssola removed the junior job label Oct 18, 2017
@mssola mssola modified the milestones: Release 2.3, Release 2.4 Oct 18, 2017
@mssola mssola modified the milestones: Release 2.4, Release 2.5 Jan 18, 2018
@mssola mssola removed this from the Release 2.5 milestone Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants