ci: added staticcheck and vet as linters #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked it as WIP because of the new cpu collector, which is not used and |
|
Nice lets get this one going, when we are ready with the collector then? |
Yes, because right now the |
mssola
force-pushed
the
staticcheck
branch
9 times, most recently
from
b0028d9
to
bb710c7
Compare
|
In the end I had to split off the linting job into a new github action because running inside of the SLES container where the tests are run was basically impossible. |
Following Go's standards, we should be using `go vet` and `staticcheck` as well. Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
Tools like staticcheck have problems running on the SLES container being used to run unit tests. Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Go's standards, we should be using
go vetandstaticcheckas well.