Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove EC2 images with 'pcw_ignore' tag set to '1' #388

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

pdostal
Copy link
Collaborator

@pdostal pdostal commented Jun 24, 2024

  • Related ticket: poo#162770
  • Verification run: Tested manage.py cleanup manually with dry_run = True as well as dry_run = False with the same output:
$ podman run  -v ./pcw.ini:/etc/pcw.ini -v ./creds/:/var/pcw -v ./code/:/pcw -t localhost/suse/qac/pcw-devel:latest
"python3 manage.py cleanup"
2024-06-25 14:16:49,824 ocw.lib.cleanup INFO     [ccoe] Run cleanup for EC2
2024-06-25 14:16:50,101 ocw.lib.ec2  INFO     [ccoe] Do cleanup of images, snapshots and volumes
2024-06-25 14:16:50,101 ocw.lib.ec2  DEBUG    [ccoe] Call cleanup_images
2024-06-25 14:16:50,964 ocw.lib.ec2  DEBUG    [ccoe] Found 0 images in eu-north-1
2024-06-25 14:16:51,732 ocw.lib.ec2  DEBUG    [ccoe] Found 4 images in eu-west-1
2024-06-25 14:16:51,732 ocw.lib.ec2  DEBUG    [ccoe] Ignoring openqa-SLES15-SP6.x86_64-1.0.0-EC2-Build1.26.raw.xz due to 'pcw_ignore' tag set to '1'
2024-06-25 14:16:51,732 ocw.lib.ec2  DEBUG    [ccoe] Ignoring openqa-SLES15-SP6-BYOS.aarch64-1.0.0-EC2-Build1.26.raw.xz due to 'pcw_ignore' tag set
to '1'
2024-06-25 14:16:51,732 ocw.lib.ec2  DEBUG    [ccoe] Ignoring openqa-SLES15-SP6.aarch64-1.0.0-EC2-Build1.26.raw.xz due to 'pcw_ignore' tag set to '1
'
2024-06-25 14:16:51,732 ocw.lib.ec2  DEBUG    [ccoe] Ignoring openqa-SLES15-SP6-BYOS.x86_64-1.0.0-EC2-Build1.26.raw.xz due to 'pcw_ignore' tag set t
o '1'
2024-06-25 14:17:00,524 ocw.lib.ec2  DEBUG    [ccoe] Found 0 images in eu-central-1
2024-06-25 14:17:01,011 ocw.lib.ec2  DEBUG    [ccoe] Found 0 images in us-east-1
2024-06-25 14:17:02,405 ocw.lib.ec2  DEBUG    [ccoe] Found 0 images in us-west-1

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.46%. Comparing base (48b60c2) to head (51e86da).
Report is 10 commits behind head on master.

Files Patch % Lines
ocw/lib/ec2.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
+ Coverage   78.16%   78.46%   +0.30%     
==========================================
  Files          22       22              
  Lines        1694     1717      +23     
==========================================
+ Hits         1324     1347      +23     
  Misses        370      370              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions. LGTM.

ocw/lib/ec2.py Outdated Show resolved Hide resolved
ocw/lib/ec2.py Outdated Show resolved Hide resolved
@ricardobranco777 ricardobranco777 merged commit 6c2c0c3 into SUSE:master Jun 25, 2024
12 checks passed
@asmorodskyi
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants