Use RMT::VERSION in Makefile #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikapelyukhin
force-pushed
the
makefile_version_from_ruby
branch
from
9f02068
to
76b74f4
Compare
Generated by 🚫 Danger |
Sergeykot
reviewed
Jul 6, 2018
| @@ -1,5 +1,5 @@ | |||
| NAME = rmt-server | |||
| VERSION = 1.0.4 | |||
| VERSION = $(shell ruby -e 'require "./lib/rmt.rb"; print RMT::VERSION') | |||
There was a problem hiding this comment.
when I execute the command I get shell: command not found
could $(ruby -e 'require "./lib/rmt.rb"; print RMT::VERSION') also work?
There was a problem hiding this comment.
How are you executing the command/what command are you executing?
There was a problem hiding this comment.
Run make dist. $(shell ... ) is Makefile syntax to execute shell commands.
There was a problem hiding this comment.
sry I did run in via my CLI to test.
packaging works fore me so never mind
|
really nice improvement!! edit: OK my funny gif is not working. I wanted to embed: https://media.giphy.com/media/2XtEQpM97Lvhe/giphy.gif |
ikapelyukhin
force-pushed
the
makefile_version_from_ruby
branch
from
7a26577
to
3102ed4
Compare
ikapelyukhin
force-pushed
the
makefile_version_from_ruby
branch
from
3102ed4
to
c636b91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces number of places where the version has to be specified by one.