Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the sapcontrol SOAP XML webservice client importable #59

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

stefanotorresi
Copy link
Collaborator

for external consumption, like in the Trento project.

Copy link
Contributor

@MalloZup MalloZup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if following standard golang pkg is better.

But I I think also lib , is less uncommon but still okaish. anyways nothing I can block as not maintainer. As personal pov , I would use pkg since project is using already a bit of the layout mentioned

Copy link

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciated @stefanotorresi

@stefanotorresi
Copy link
Collaborator Author

@MalloZup I thought about that but pkg would be ambiguous with the existing packaging directory, so I think lib makes it more clear that code in there can be used as an external library.

@stefanotorresi stefanotorresi merged commit 68bbf2f into SUSE:master Apr 26, 2021
@stefanotorresi stefanotorresi deleted the move-sapcontrol-ws branch April 26, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants