Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issues found during the first intensive tour of inspection #22

Merged
merged 7 commits into from
May 6, 2019

Conversation

angelabriel
Copy link
Collaborator

  • handle override value for ShmFileSystemSizeMB and/or VSZ_TMPFS_PERCENT correctly, especially during calculation of ShmFileSystemSizeMB
  • skip unsupported block devices (at the moment: dm-*)
  • allow override file to exclude all limit settings of the note from being changed - so handle all limits as 'untouched'
  • avoid confusing verify message, if there are no notes or solutions applied
  • support short form of service name in override file
  • bash-completion: added 'help' and 'create'
  • support different formats for the log messages depending on the destination (log file or stderr/stdout)
    (the logging topic needs some more attention. I will have a look next week and will add some small changes. Additionally I will start the discussion with Alliance team, what exactly we want to log, where and with which severity. But this will be a mid-term change.)

Copy link
Member

@diegoakechi diegoakechi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@angelabriel angelabriel merged commit a478eaf into SUSE:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants