Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional fixes for multi-queue I/O scheduler support (bsc#1152598) #29

Merged
merged 4 commits into from
Nov 12, 2019

Conversation

angelabriel
Copy link
Collaborator

suppress double print of the scheduler information during 'apply' operation
correct the information about the used schedulers in case the settings should remain untouched

Inform the customer that - by intention - the command
'saptune note customise '
does not apply changes immediately. It just changes the configuration in the 'override' file. These changes have to be applied in a second step.
This is explained in the man page saptune_v2(8) and a message is printed in the logs and on the screen to inform the customer. (bsc#1142467)

Add warning to man page, not to rename/remove/modify active configurations (bsc#1149002)

suppress double print of the scheduler information during 'apply' operation
correct the information about the used schedulers in case the settings should remain untouched
Copy link
Member

@diegoakechi diegoakechi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some small nitpicks on the messages.

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@angelabriel angelabriel merged commit a1e1c27 into SUSE:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants