This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Redo how secrets are generated #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
force-pushed
the
0s4zlOZg-redo-how-secrets-are-generated
branch
3 times, most recently
from
08d3528
to
b4f831d
Compare
jandubois
force-pushed
the
0s4zlOZg-redo-how-secrets-are-generated
branch
4 times, most recently
from
26e6e28
to
1266145
Compare
mook-as
suggested changes
Mar 21, 2018
Jenkinsfile
Outdated
| @@ -63,7 +63,9 @@ void runTest(String testName) { | |||
| value = "tcp.#{domain}" if env['name'] == 'TCP_DOMAIN' | |||
| env['value'] = value.to_s | |||
|
|
|||
| env['valueFrom']['secretKeyRef']['name'] = capsecret if env['valueFrom'] && env['valueFrom']['secretKeyRef'] | |||
| if env['name'] != 'CLUSTER_ADMIN_PASSWORD' && env['name'] != 'UAA_ADMIN_CLIENT_SECRET' && env['name'] != 'UAA_CA_CERT' | |||
| env['valueFrom']['secretKeyRef']['name'] = capsecret if env['valueFrom'] && env['valueFrom']['secretKeyRef'] | |||
There was a problem hiding this comment.
Having a foo if bar inside a if … seems kind of weird. (But I would have also done something like unless %w(CLUSTER_ADMIN_PASSWORD UAA_ADMIN_CLIENT_SECRET UAA_CA_CERT).include? env['name'] or a case statement)
bin/dev/install_tools.sh
Outdated
| @@ -7,7 +7,7 @@ set -vx | |||
| SCF_BIN_DIR="${SCF_BIN_DIR:-output/bin}" | |||
|
|
|||
| # Tool locations | |||
| s3="https://cf-opensusefs2.s3.amazonaws.com/fissile" | |||
| s3="https://cf-opensusefs2.s3.amazonaws.com/fissile/checks" | |||
There was a problem hiding this comment.
(Reminder to not merge with the checks in place)
jandubois
force-pushed
the
0s4zlOZg-redo-how-secrets-are-generated
branch
2 times, most recently
from
338b3bd
to
e3c4d6e
Compare
mook-as
approved these changes
Mar 23, 2018
jandubois
force-pushed
the
0s4zlOZg-redo-how-secrets-are-generated
branch
from
e3c4d6e
to
1d4c201
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.