Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph_bootstrap_deployment: log cephadm and ceph-bootstrap version #86

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

smithfarm
Copy link
Collaborator

This information is logged to facilitate faster debugging of problems
arising out of incompatibility between cephadm and ceph-bootstrap.

Fixes: #85
Signed-off-by: Nathan Cutler ncutler@suse.com

@smithfarm smithfarm requested a review from rjfd February 4, 2020 13:24
This information is logged to facilitate faster debugging of problems
arising out of incompatibility between cephadm and ceph-bootstrap.

Fixes: SUSE#85
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
Copy link
Collaborator Author

    admin: ++ zypper lr -upEP
    admin: #  | Alias               | Name                        | Enabled | GPG Check | Refresh | Priority | URI                                                                                              
    admin: ---+---------------------+-----------------------------+---------+-----------+---------+----------+--------------------------------------------------------------------------------------------------
    admin:  1 | octopus-repo1       | octopus-repo1               | Yes     | (r ) Yes  | No      |   98     | https://download.opensuse.org/repositories/filesystems:/ceph:/master:/upstream/openSUSE_Leap_15.2
    admin:  6 | repo-non-oss        | Non-OSS Repository          | Yes     | (r ) Yes  | No      |   99     | http://download.opensuse.org/distribution/leap/15.2/repo/non-oss/                                
    admin:  7 | repo-oss            | Main Repository             | Yes     | (r ) Yes  | No      |   99     | http://download.opensuse.org/distribution/leap/15.2/repo/oss/                                    
    admin: 10 | repo-update         | Main Update Repository      | Yes     | (r ) Yes  | No      |   99     | http://download.opensuse.org/update/leap/15.2/oss/                                               
    admin: 11 | repo-update-non-oss | Update Repository (Non-Oss) | Yes     | (r ) Yes  | No      |   99     | http://download.opensuse.org/update/leap/15.2/non-oss/                                           
    admin: ++ zypper info cephadm
    admin: ++ grep -E '(^Repo|^Version)'
    admin: Repository     : octopus-repo1                       
    admin: Version        : 15.1.0-lp152.183.1                  
    admin: ++ ceph-bootstrap --version
    admin: ceph-bootstrap 15.0.2+1580743520.g1c1e49b

@smithfarm
Copy link
Collaborator Author

In a follow-up PR, I'd like to consider breaking ceph_bootstrap_deployment.sh into two scripts:

The first one, called "ceph_bootstrap_prep.sh" would end with this version information. Sesdev would take the "cephadm" and "ceph-bootstrap" versions and check that they are compatible. Then (and only if the versions are not known to be incompatible) it would run the second part, "ceph_bootstrap_deployment.sh", which would just trigger ceph-bootstrap deploy and possibly the qa tests.

@@ -71,6 +71,10 @@ ceph-bootstrap config /Deployment/Dashboard/password set admin

ceph-bootstrap config ls

zypper lr -upEP
zypper info cephadm | grep -E '(^Repo|^Version)'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a cephadm --version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea to have one, but it's not needed for this PR because cephadm is not installed at this point. (It gets installed by ceph-bootstrap deploy)

Copy link
Contributor

@rjfd rjfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Before running ceph-bootstrap deploy, print versions of ceph-bootstrap and cephadm
3 participants