-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceph_bootstrap_deployment: log cephadm and ceph-bootstrap version #86
Conversation
seslib/templates/ceph-bootstrap/ceph_bootstrap_deployment.sh.j2
Outdated
Show resolved
Hide resolved
This information is logged to facilitate faster debugging of problems arising out of incompatibility between cephadm and ceph-bootstrap. Fixes: SUSE#85 Signed-off-by: Nathan Cutler <ncutler@suse.com>
ea80eac
to
76948f1
Compare
|
In a follow-up PR, I'd like to consider breaking The first one, called "ceph_bootstrap_prep.sh" would end with this version information. Sesdev would take the "cephadm" and "ceph-bootstrap" versions and check that they are compatible. Then (and only if the versions are not known to be incompatible) it would run the second part, "ceph_bootstrap_deployment.sh", which would just trigger |
@@ -71,6 +71,10 @@ ceph-bootstrap config /Deployment/Dashboard/password set admin | |||
|
|||
ceph-bootstrap config ls | |||
|
|||
zypper lr -upEP | |||
zypper info cephadm | grep -E '(^Repo|^Version)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need a cephadm --version
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good idea to have one, but it's not needed for this PR because cephadm
is not installed at this point. (It gets installed by ceph-bootstrap deploy
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This information is logged to facilitate faster debugging of problems
arising out of incompatibility between cephadm and ceph-bootstrap.
Fixes: #85
Signed-off-by: Nathan Cutler ncutler@suse.com