Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Repository branch from ci-repo label #1134

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

pablochacin
Copy link
Contributor

Why is this PR needed?

In #1113 it was introduced a logic for using a branch of the CaaSP Devel repository, to allow testing packages in a PR. However, this logic was based on a naming convention that results unclear. Instead, this PR introduces using a ci label to indicate if a repository branch should be used for the PR.

What does this PR do?

If ci-repo label is specified, set the BRANCH_REPO environment variable to add this repo branch to the cluster nodes.

Merge restrictions

(Please do not edit this)

We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:

What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

If ci-repo label is specified, set the BRANCH_REPO environment
variable to add this repo branch to the cluster nodes.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
Copy link
Collaborator

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I also prefer this way of setting it, it is more obvious

@pablochacin pablochacin merged commit 8b55cf1 into SUSE:master Jun 5, 2020
jordimassaguerpla pushed a commit that referenced this pull request Jun 5, 2020
If ci-repo label is specified, set the BRANCH_REPO environment
variable to add this repo branch to the cluster nodes.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
mmnelemane pushed a commit to mmnelemane/skuba that referenced this pull request Jul 3, 2020
If ci-repo label is specified, set the BRANCH_REPO environment
variable to add this repo branch to the cluster nodes.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
pablochacin pushed a commit to pablochacin/skuba that referenced this pull request Jul 9, 2020
If ci-repo label is specified, set the BRANCH_REPO environment
variable to add this repo branch to the cluster nodes.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
(cherry picked from commit 8b55cf1)
@pablochacin pablochacin deleted the use-repo-from-ci-tags branch July 10, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants