Merge upstream #408
Merged
Merge upstream #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
richard-cox
commented
Jul 9, 2020
richard-cox
commented
- Also includes Improve recent and favourites display cloudfoundry/stratos#4421
* Remove action entityLocation (not used) * Fix restage - fixes cloudfoundry#4392 * Remove RequestEntityLocation
* Update icons * Update docker icon and optimize other pngs * Improve resolution of container icon * Update e2e test for new icons
…, improve code splitting (cloudfoundry#4412) * Move out cf themese from _all-theme & remove custom cf table sort/filter field widths * Move cf routes out of app.routing & move out cf route modules from cf package module (fixes code splitting) * Fix autoscaler e2e test * Split out CF modules and router imports into custom module * Create cf-autoscaler package & routing modules - note - CfAutoscalerModule is imported in CfAutoscalerPackageModule - note - AutoscalerModule should be brought back into CfAutoscalerModule (stepper is lazy loaded.. but content missing elsewhere) * Fix autoscaler e2e test #2 * Fix app autoscaler tab widgets, import using package name * Move CfAutoscalerModule (app AS tab) out of always loaded AS package into lazy loaded app module * Add comments, fix e2e test following app-running-instance change * Allow routes to be applied to stratos navigation root without appearing in side nav * Fix app-card-app-usage on app AS tab - only seen when policy does not contain metrics restrictions - fixes by bringing in CloudFoundrySharedModule again to CfAutoscalerModule - means an also use app-running-instances again - i've checked the chunks & sizes, they're similar as before * Move CloudFoundrySharedModule out of CloudFoundryPackageModule * Add comments * Bring back in smaller search/sort input fields in main lists * Bring back lost styling
* Use smaller page header on desktop browsers * Change tooltip appear time
* Allow ng build to be un from any subfolder * Add support for packages in orgs
…loudfoundry#4417) * Fetch service in service instances card via store rather than inline - fixes cloudfoundry#4397 - accessing entity via this.serviceInstanceEntity.entity.service_plan.entity.service.entity.service_broker_guid can sometimes fail - fetch service, and thus service broker guid, from store instead - this matches the table way of getting the broker * Fix unit test * Fix & Improve Service Instance Card - ensure async properties have async pipe in html - bind to params rather than properties
* Remove old symlink files in pre-4.0 Strtaos * Also clean out favicon. Log when removing file Co-authored-by: Richard Cox <richard.cox@suse.com>
- had a `top` with the old banner height
…dry#4429) * E2E Debugging * Fix travis file * Reset travis file * Furher debugging * Report errors if we fail to write messages to web sockets * Add client acknowledgement on close * Fix backend unit tests. Undo travis change * Remove debugging * Remove protractor-console
- favourite & recent icon changes
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
==========================================
+ Coverage 56.20% 56.34% +0.14%
==========================================
Files 891 891
Lines 29209 29143 -66
Branches 4232 4217 -15
==========================================
+ Hits 16416 16421 +5
+ Misses 12793 12722 -71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.