Fix the extapi.bc path not found issue #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1212 +/- ##
==========================================
- Coverage 64.50% 64.49% -0.02%
==========================================
Files 223 223
Lines 23663 23670 +7
==========================================
+ Hits 15263 15265 +2
- Misses 8400 8405 +5
|
251
reviewed
Oct 5, 2023
| @@ -38,7 +38,7 @@ | |||
|
|
|||
| /// For a more detailed explanation of how External APIs are handled in SVF, please refer to the SVF Wiki: https://github.com/SVF-tools/SVF/wiki/Handling-External-APIs-with-extapi.c | |||
|
|
|||
| #define EXTAPI_BC_PATH "Release-build/svf-llvm/extapi.bc" | |||
| #define DEFUALT_EXTAPI_BC_PATH "/svf-llvm/extapi.bc" // Default path to extapi.bc through the SVF build method(e.g. source ./build.sh) | |||
| // 1. Set extapi.bc path through setExtBcPath() method | ||
| if (!extBcPath.empty() && !stat(extBcPath.c_str(), &statbuf)) | ||
| return extBcPath; | ||
|
|
There was a problem hiding this comment.
You could simplify that function and make it much faster:
- add a short circuit in the beginning:
if (!extBcPath.empty())
return extBcPath;- just assemble the paths via getenv, getFilePath, ... as below but than forward them to
setExtBcPathand do the stat call there once (and not for every call to that function)
This should also remove the code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.