Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lang.ru.js #966

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Update lang.ru.js #966

merged 1 commit into from
Apr 25, 2024

Conversation

KamilOcean
Copy link
Contributor

I'm a native Russian speaker, I've added some new lines

PR description

Checklist

Note that we require UI tests to ensure that the added feature will not be
nixed by some future fix and that there is at least some test-as-documentation
to indicate how the fix or enhancement is expected to behave.

  • - Added Cypress UI tests
  • - Ran npm test, ensuring linting passes and that Cypress UI tests keep
    coverage to at least the same percent (reflected in the coverage badge
    that should be updated after the tests run)
  • - Added any user documentation. Though not required, this can be a big
    help both for future users and for the PR reviewer.

I'm a native Russian speaker, I've add some new lines
@@ -216,12 +216,12 @@ export default {
snapping_stepsize: 'Шаг привязки:',
grid_color: 'Цвет сетки',
done: 'Done',
change_xxx_color: 'Change xxx color',
change_xxx_color: 'Поменять xxx цвет',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not sound as Russian?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Russian. What does xxx mean? I thought it's like a template, isn't it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. Thank you for the contribution

@jfhenon jfhenon merged commit a4dc7f7 into SVG-Edit:master Apr 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants