Bugix for #207 and #208 and Static Code Analysis Fixes #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heritago logos added to the reporsitory to be used in the project. Logos are handiwork of @isik5
TalatCikikci
changed the title
…n Fixes Fixed issues SWE574-Groupago#207 and SWE574-Groupago#208 by setting the target_id as the request URL. Ran code inspection and fixed most of the static code analysis issues.
Fixed the PEP8 issue in settings.py (no new line at the end of file)
TalatCikikci
added a commit
to TalatCikikci/heritago
that referenced
this pull request
May 28, 2017
An issue was introduced to the "get_file" method of MultimediaFileView class. This was fixed by reverting the changes.
TalatCikikci
added a commit
to TalatCikikci/heritago
that referenced
this pull request
May 28, 2017
This reverts commit f70fc00.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for #207 #208
Code inspection fixes.