Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 adding wait on stop during recreation #102

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

lvenier
Copy link
Contributor

@lvenier lvenier commented Jun 6, 2024

Some people have some "lazy" containers that can take time to be stopped.
Adding the wait api call after the docker stop during the recreation to avoid stopping issues or delayes.

@lvenier lvenier requested review from linkdd and fanshan June 6, 2024 11:11
@lvenier lvenier self-assigned this Jun 6, 2024
@fanshan fanshan merged commit b3e47ca into main Jun 6, 2024
1 check passed
@fanshan fanshan deleted the add_wait_on_stop_for_recreate branch June 6, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants