Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Add hurl for testing #97

Merged
merged 7 commits into from
Jun 5, 2024
Merged

✅ Add hurl for testing #97

merged 7 commits into from
Jun 5, 2024

Conversation

dzove855
Copy link
Member

No description provided.

@dzove855 dzove855 self-assigned this May 16, 2024
@linkdd
Copy link
Collaborator

linkdd commented May 16, 2024

Hmm, seems like you got no response assertion there.

I also recommend adding the --test flag to hurl invocation.

@dzove855
Copy link
Member Author

Hmm, seems like you got no response assertion there.

I also recommend adding the --test flag to hurl invocation.

I added it with the --test flag directly inside the CI

lvenier
lvenier reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@lvenier lvenier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why dont you add the tests in the CI ? I dont see them added. pls show me if I missed something

@dzove855
Copy link
Member Author

Why dont you add the tests in the CI ? I dont see them added. pls show me if I missed something

It is added in the ci:
.github/workflows/pr_ci.yml

@dzove855 dzove855 marked this pull request as ready for review June 5, 2024 05:32
@dzove855 dzove855 merged commit b2676bf into main Jun 5, 2024
1 check passed
@dzove855 dzove855 deleted the improve_tests branch June 5, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvenier lvenier lvenier left review comments

@linkdd linkdd linkdd approved these changes

@fanshan fanshan Awaiting requested review from fanshan

Assignees

@dzove855 dzove855

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzove855 @linkdd @lvenier