Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog amdgpu #55

Merged
merged 7 commits into from
Jun 28, 2017
Merged

blog amdgpu #55

merged 7 commits into from
Jun 28, 2017

Conversation

jcfrosty
Copy link
Collaborator

New AMDGPU blog.

@jcfrosty jcfrosty requested a review from Ryuno-Ki June 26, 2017 17:39
@jcfrosty jcfrosty mentioned this pull request Jun 26, 2017
@Enlik
Copy link
Member

Enlik commented Jun 26, 2017

(continuing from issue #54)
Title suggests 26.06, file name 24.06. Minor stuff but can be annoying when someone gets misguided by this whilst doing something with the repository.

@jcfrosty jcfrosty changed the title blog amdgpu 2017.06.26 blog amdgpu Jun 26, 2017
@jcfrosty
Copy link
Collaborator Author

Good point on the naming and the display code conversion. I've fixed the article to say DAL/HAL conversion. Also updated the name to remove confusion with releases.

@Ryuno-Ki Ryuno-Ki merged commit 369defc into master Jun 28, 2017
@Ryuno-Ki Ryuno-Ki deleted the jcfrosty-blog-amdgpu branch June 28, 2017 18:08
@Ryuno-Ki
Copy link
Collaborator

I still would like to have seen more subheadings, but you already tool over our suggestions and Enlik approved it, so...

Thanks for your contribution!

@Enlik will you take care for publication?

@Enlik
Copy link
Member

Enlik commented Jun 28, 2017

I used it to mark "I think it's OK" for no better button or icon (I could have used a comment though).

I don't know how to publish the article; I thought you would do it. :)

@jcfrosty
Copy link
Collaborator Author

jcfrosty commented Jun 28, 2017 via email

@Ryuno-Ki
Copy link
Collaborator

Ah, it's already live.

After digging through my IRC logs (thanks, @optiz0r!) I found out how we did it.
This may be worth documenting in our README.md.

When accepting a Pull Request, Circle CI kicks in. It merges the changes into gh-pages, so they show up on Sabayon's GitHub Page and are synched to the live instance quickly afterwards.

@optiz0r
Copy link
Contributor

optiz0r commented Jun 29, 2017

Bullet points in "So when can we expect to see support" paragraph haven't rendered properly. Otherwise LGTM.

@jcfrosty
Copy link
Collaborator Author

I've gone ahead and fixed the bullet points. Seems it needed a line between the paragraph and the bullet lines.

@Enlik
Copy link
Member

Enlik commented Jun 29, 2017

Ah, it's already live.

It's actually only on the "next.sabayon.org" (I'm not sure if you meant that).

@Enlik
Copy link
Member

Enlik commented Jun 29, 2017

Ugh, not sure how others thing but I'd prefer this PR (that consists of several small commits) be either merged or squashed.
Not a big issue anyway.

@jcfrosty
Copy link
Collaborator Author

jcfrosty commented Jun 29, 2017 via email

@Ryuno-Ki
Copy link
Collaborator

@Enlik Lately I work mostly with rebases, but can pick another strategy next time.

@jcfrosty Circle CI takes care of that.

@Enlik
Copy link
Member

Enlik commented Jul 2, 2017

FYI, it looks like it has to be merged manually to the production repository. @jcfrosty opened a PR there.

@Ryuno-Ki
Copy link
Collaborator

Ah, yes. How could I forget Sabayon/woohoo?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants