Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuist configuration #20

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add Tuist configuration #20

wants to merge 7 commits into from

Conversation

DimitarNestorov
Copy link
Contributor

@DimitarNestorov DimitarNestorov commented Dec 29, 2021

Discord thread: https://discord.com/channels/922963239241928705/925863978511503400

To do:

  • Remove Wallet.xcodeproj
  • Have only one instance of com.safari-wallet in the whole project
    • Remove instances from entitlements
    • Remove instances from Constants.swift
  • Integrate the JavaScript build process in the app build phases
    • Use Yarn v3
    • Download an exact version of Yarn
    • Install all dependencies
    • Support for nvm
    • Either detect if parcel watch is running and skip the build process or introduce a SKIP_JAVASCRIPT_BUILD variable in a .xcconfig
    • Add incremental in the TypeScript configuration
  • Create a script which generates a post-checkout hook which runs tuist dependencies fetch and tuist generate
  • Generate a single Assets.swift file
  • Migrate away from keys.swift
    • Generate a API Keys.xcconfig file and ask for the keys when running tuist focus/tuist generate
      • File should show up in Xcode. Should have a reference in the Derived group but the file should be in a different folder since Derived is deleted when running tuist focus/tuist generate.
      • If all keys are already in the file don't ask again. If there are missing keys in the file ask only for those keys.
    • Add each key to the Info.plists
    • Make ApiKeys.swift:
      enum ApiKeys {
        static let alchemyMainnet = try! Configuration.value(for: "WALLET_ALCHEMY_MAINNET_KEY")
        static let alchemyRopsten = try! Configuration.value(for: "WALLET_ALCHEMY_ROPSTEN_KEY")
        static let infuraRopsten = try! Configuration.value(for: "WALLET_INFURA_ROPSTEN_KEY")
        static let infuraMainnet = try! Configuration.value(for: "WALLET_INFURA_MAINNET_KEY")
        static let covalent = try! Configuration.value(for: "WALLET_COVALENT_KEY")
        static let unmarshal = try! Configuration.value(for: "WALLET_UNMARSHAL_KEY")
        static let etherscan = try! Configuration.value(for: "WALLET_ETHERSCAN_KEY")
      }

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 29, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ddac387
Status: ✅  Deploy successful!
Preview URL: https://4f385657.ui-eff.pages.dev

View logs

@ronaldmannak
Copy link
Contributor

What do we need to do to rebuild the project file locally?

@DimitarNestorov
Copy link
Contributor Author

DimitarNestorov commented Dec 29, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants