Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform Extensive Code Refactoring #8

Merged
merged 64 commits into from
Dec 30, 2020
Merged

Perform Extensive Code Refactoring #8

merged 64 commits into from
Dec 30, 2020

Conversation

SafdarJamal
Copy link
Owner

  • Refactor all components to use React Hooks.
  • Simplified components rendering logic.
  • Delete API constants.
  • Create a utils library.
  • Create a Layout component.
  • Implement runtime type checking of props with prop-types.
  • Move data handling logic into the Main component.

@SafdarJamal
Create utils library
0b84197
@SafdarJamal
Integrate utils library
122c41a
@SafdarJamal
Refactor countdownTime constant
ba9a5b4
@SafdarJamal
Refactor numOfQuestions constant
379156d
@SafdarJamal
Refactor constants index
25933fc
@SafdarJamal
Update App component test
1cb5cfc
@SafdarJamal
Extract images from assets
b959533
@SafdarJamal
Delete api constants
439e37d
@SafdarJamal
Refactor ShareButton component
b48ce02
@SafdarJamal
Refactor Offline component
decfb08
@SafdarJamal
Refactor Loader component
c718b49
@SafdarJamal
Refactor Countdown component
a51b55d
@SafdarJamal
Refactor Result component
cbf6cc0
@SafdarJamal
Refactor App component
9c5964d
@SafdarJamal
Refactor Header component
6f4d0e5
@SafdarJamal
Refactor Main component
54ff0db
@SafdarJamal
Refactor Quiz component
02bdf09
@SafdarJamal
Fix utils export
29bd40a
@SafdarJamal
Improve names of variables in App component
67cd9f9
@SafdarJamal
Improve variables names in Quiz component
7ca4b79
@SafdarJamal
Refactor Result component to reflect Quiz changes
57df686
@SafdarJamal
Delete unused code
565c80f
@SafdarJamal
Change variables names in Quiz component
63d68ba
@SafdarJamal
Delete duplicate logic
f7f3fb3
@SafdarJamal
Simplified Result component rendering logic
f6d43a1
@SafdarJamal
Refactor quiz "options" rendering logic
65bb2eb
@SafdarJamal
Refactor "retakeQuiz" functionality
ae0c99f
@SafdarJamal
Perform massive code refactoring in Quiz component
4f30cc8
@SafdarJamal
Wrap result props into an object
d0ef7f6
@SafdarJamal
Refactor App component to reflect Quiz changes
30396f4
@SafdarJamal
Fix constants export
a0a6cb9
@SafdarJamal
Rename countdown time state
a3d8798
@SafdarJamal
Rename questions type state
411eaa4
@SafdarJamal
Rename num of questions state
8215cb4
@SafdarJamal
Add totalQuestions property in resultData object
50ee75b
@SafdarJamal
Create calculateScore utility
766a68d
@SafdarJamal
Refactor timeConverter utility
ed1f401
@SafdarJamal
Refactor manual calculating of "score"
28b47a0 
Replace manual calculating of "score" with calculateScore utility
in Stats component
@SafdarJamal
Refactor Countdown component
01bf9fb
@SafdarJamal
Refactor Quiz and Result components
f3ae52e 
Refactor Quiz and Result components to reflect Countdown changes
@SafdarJamal
Implement type checking of Stats component props
e55aac5
@SafdarJamal
Implement type checking of QA component props
2e3be66
@SafdarJamal
Implement type checking of Result component props
4f91736
@SafdarJamal
Implement type checking of Quiz component props
1e6e518
@SafdarJamal
Implement type checking of Main component props
e9a6ed7
@SafdarJamal
Implement type checking of Countdown component props
e7e4b92
@SafdarJamal
Update constants index
f5bb8e0
@SafdarJamal
Rename timesUp function to timeOver
f67dfdd
@SafdarJamal
Update App test
0fbde22
@SafdarJamal
Omit unnecessary state updates
05996cf
@SafdarJamal
Create getLetterByNumber utility
f90d9db
@SafdarJamal
Refactor Quiz component
9f2700d 
Refactor Quiz component to use getLetterByNumber utility
@SafdarJamal
Fix conditional rendering of app components
5b43dfb
@SafdarJamal
Fix countdown timer
146c6e3
@SafdarJamal
Fix eslint warning in Countdown component
0af184a
@SafdarJamal
Fix takenTime state diffrence
3ab937c 
Fix takenTime state diffrence between Countdown and Result component
@SafdarJamal
Update dependencies
f27838f
@SafdarJamal SafdarJamal added the enhancement A new feature or enhancement of an existing feature. label Dec 30, 2020
@SafdarJamal SafdarJamal merged commit 9e20e6c into development Dec 30, 2020
@SafdarJamal SafdarJamal deleted the feature/refactor-source-code branch December 30, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SafdarJamal