Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneHotEncoder should maintain column order #109

Closed
lars-reimann opened this issue Mar 28, 2023 · 1 comment · Fixed by #195
Closed

OneHotEncoder should maintain column order #109

lars-reimann opened this issue Mar 28, 2023 · 1 comment · Fixed by #195
Assignees
Labels
enhancement 💡 New feature or request released Included in a release

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Mar 28, 2023

Is your feature request related to a problem?

OneHotEncoder.transform currently appends the one-hot-encoded columns at the end of the result. Likewise, OneHotEncoder.inverse_transform appends the decoded columns at the end of the result. Because of this, inverse_transform is generally not able to restore the original table exactly.

Example:

Input:

col1 col2
"a" 0
"b" 1

Result of transforming "a":

col2 col1_a col1_b
0 1 0
1 0 1

Result of inverse transform:

col2 col1
0 "a"
1 "b"

Desired solution

Produce the following results instead:

Result of transforming "a":

col1_a col1_b col2
1 0 0
0 1 1

Result of inverse transform:

col1 col2
"a" 0
"b" 1

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response

@lars-reimann lars-reimann added the enhancement 💡 New feature or request label Mar 28, 2023
@Marsmaennchen221 Marsmaennchen221 self-assigned this Apr 16, 2023
Marsmaennchen221 added a commit that referenced this issue Apr 16, 2023
…ll columns were fitted

`OneHotEncoder.inverse_transform` now maintains the column order from the original table; added test for this behaviour (#109)
lars-reimann added a commit that referenced this issue Apr 18, 2023
…r from the original table (#195)

Closes #109.

### Summary of Changes

`OneHotEncoder.inverse_transform` now maintains the column order from
the original table (#109)
Fixed bug with `OneHotEncoder.inverse_transform` to not work if not all
columns were fitted
New feature columns in `OneHotEncoder` will now be inserted where the
combined columns were in the original table

---------

Co-authored-by: megalinter-bot <129584137+megalinter-bot@users.noreply.github.com>
Co-authored-by: Lars Reimann <mail@larsreimann.com>
lars-reimann pushed a commit that referenced this issue Apr 21, 2023
## [0.11.0](v0.10.0...v0.11.0) (2023-04-21)

### Features

* `OneHotEncoder.inverse_transform` now maintains the column order from the original table ([#195](#195)) ([3ec0041](3ec0041)), closes [#109](#109) [#109](#109)
* add `plot_` prefix back to plotting methods ([#212](#212)) ([e50c3b0](e50c3b0)), closes [#211](#211)
* adjust `Column`, `Schema` and `Table` to changes in `Row` ([#216](#216)) ([ca3eebb](ca3eebb))
* back `Row` by a `polars.DataFrame` ([#214](#214)) ([62ca34d](62ca34d)), closes [#196](#196) [#149](#149)
* clean up `Row` class ([#215](#215)) ([b12fc68](b12fc68))
* convert between `Row` and `dict` ([#206](#206)) ([e98b653](e98b653)), closes [#204](#204)
* convert between a `dict` and a `Table` ([#198](#198)) ([2a5089e](2a5089e)), closes [#197](#197)
* create column types for `polars` data types ([#208](#208)) ([e18b362](e18b362)), closes [#196](#196)
* dataframe interchange protocol ([#200](#200)) ([bea976a](bea976a)), closes [#199](#199)
* move existing ML solutions into `safeds.ml.classical` package ([#213](#213)) ([655f07f](655f07f)), closes [#210](#210)

### Bug Fixes

* `table.keep_only_columns` now maps column names to correct data ([#194](#194)) ([459ab75](459ab75)), closes [#115](#115)
* typo in type hint ([#184](#184)) ([e79727d](e79727d)), closes [#180](#180)
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💡 New feature or request released Included in a release
Projects
Archived in project
2 participants