Skip to content

feat: adjust Column, Schema and Table to changes in Row#216

Merged
lars-reimann merged 2 commits into
mainfrom
rename_some_stuff
Apr 20, 2023
Merged

feat: adjust Column, Schema and Table to changes in Row#216
lars-reimann merged 2 commits into
mainfrom
rename_some_stuff

Conversation

@lars-reimann
Copy link
Copy Markdown
Member

@lars-reimann lars-reimann commented Apr 20, 2023

Summary of Changes

  • In Column:

    • Rename count to n_rows and make it a property
  • In Schema:

    • Rename get_column_names to column_names and make it a property
    • Rename get_type_of_column to get_column_type
  • In Table:

    • Rename count_columns to n_columns and make it a property
    • Rename count_rows to n_rows and make it a property
    • Rename get_type_of_column to get_column_type
    • Remove row count from summary since it's the same for all columns anyway

@lars-reimann
Copy link
Copy Markdown
Member Author

lars-reimann commented Apr 20, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 43 0 0 1.25s
✅ PYTHON mypy 43 0 1.98s
✅ PYTHON ruff 43 0 0 0.06s
✅ REPOSITORY git_diff yes no 0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2023

Codecov Report

Merging #216 (86aa2db) into main (b12fc68) will increase coverage by 0.01%.
The diff coverage is 94.31%.

❗ Current head 86aa2db differs from pull request most recent head a7e43cb. Consider uploading reports for the commit a7e43cb to get more accurate results

@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   96.41%   96.42%   +0.01%     
==========================================
  Files          42       42              
  Lines        1477     1482       +5     
==========================================
+ Hits         1424     1429       +5     
  Misses         53       53              
Impacted Files Coverage Δ
src/safeds/data/tabular/containers/_table.py 93.91% <89.36%> (+0.05%) ⬆️
src/safeds/data/tabular/containers/_column.py 90.47% <100.00%> (+0.06%) ⬆️
src/safeds/data/tabular/containers/_row.py 100.00% <100.00%> (ø)
...rc/safeds/data/tabular/containers/_tagged_table.py 72.22% <100.00%> (ø)
src/safeds/data/tabular/transformation/_imputer.py 93.84% <100.00%> (ø)
...feds/data/tabular/transformation/_label_encoder.py 100.00% <100.00%> (ø)
...ds/data/tabular/transformation/_one_hot_encoder.py 100.00% <100.00%> (ø)
src/safeds/data/tabular/typing/_schema.py 100.00% <100.00%> (ø)
src/safeds/ml/classical/_util_sklearn.py 100.00% <100.00%> (ø)
...c/safeds/ml/classical/classification/_ada_boost.py 100.00% <100.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lars-reimann lars-reimann marked this pull request as ready for review April 20, 2023 17:49
@lars-reimann lars-reimann requested a review from a team as a code owner April 20, 2023 17:49
@lars-reimann lars-reimann merged commit ca3eebb into main Apr 20, 2023
@lars-reimann lars-reimann deleted the rename_some_stuff branch April 20, 2023 17:49
lars-reimann pushed a commit that referenced this pull request Apr 21, 2023
## [0.11.0](v0.10.0...v0.11.0) (2023-04-21)

### Features

* `OneHotEncoder.inverse_transform` now maintains the column order from the original table ([#195](#195)) ([3ec0041](3ec0041)), closes [#109](#109) [#109](#109)
* add `plot_` prefix back to plotting methods ([#212](#212)) ([e50c3b0](e50c3b0)), closes [#211](#211)
* adjust `Column`, `Schema` and `Table` to changes in `Row` ([#216](#216)) ([ca3eebb](ca3eebb))
* back `Row` by a `polars.DataFrame` ([#214](#214)) ([62ca34d](62ca34d)), closes [#196](#196) [#149](#149)
* clean up `Row` class ([#215](#215)) ([b12fc68](b12fc68))
* convert between `Row` and `dict` ([#206](#206)) ([e98b653](e98b653)), closes [#204](#204)
* convert between a `dict` and a `Table` ([#198](#198)) ([2a5089e](2a5089e)), closes [#197](#197)
* create column types for `polars` data types ([#208](#208)) ([e18b362](e18b362)), closes [#196](#196)
* dataframe interchange protocol ([#200](#200)) ([bea976a](bea976a)), closes [#199](#199)
* move existing ML solutions into `safeds.ml.classical` package ([#213](#213)) ([655f07f](655f07f)), closes [#210](#210)

### Bug Fixes

* `table.keep_only_columns` now maps column names to correct data ([#194](#194)) ([459ab75](459ab75)), closes [#115](#115)
* typo in type hint ([#184](#184)) ([e79727d](e79727d)), closes [#180](#180)
@lars-reimann
Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 0.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant