Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table.keep_only_columns maps column names to wrong data #115

Closed
lars-reimann opened this issue Mar 29, 2023 · 1 comment · Fixed by #194
Closed

table.keep_only_columns maps column names to wrong data #115

lars-reimann opened this issue Mar 29, 2023 · 1 comment · Fixed by #194
Assignees
@Marsmaennchen221
Labels
bug 🪲 Something isn't working released Included in a release

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Mar 29, 2023 •
edited

Describe the bug

The method keep_only_columns in the Table class returns a table with the correct columns and the correct data. However, if the order of the columns names differs between the table and the column_names argument, the column names get mapped to the wrong data: The columns names of the resulting table are still in the same order as in the original table. The data, however, is ordered like the column_names list.

To Reproduce

from safeds.data.tabular.containers import Column, Table

table = Table.from_columns(
    [
        Column("A", [1, 4]),
        Column("B", [2, 5]),
        Column("C", [3, 6]),
    ]
)

print(table.keep_only_columns(["C", "A"]))

Result:

   A  C
0  3  1
1  6  4

Expected behavior

   C  A
0  3  1
1  6  4

Columns should be ordered as specified by the column_names argument.

Screenshots (optional)

No response

Additional Context (optional)

No response
@lars-reimann lars-reimann added the bug 🪲 Something isn't working label Mar 29, 2023
@Marsmaennchen221 Marsmaennchen221 self-assigned this Apr 16, 2023
Marsmaennchen221 added a commit that referenced this issue Apr 16, 2023
@Marsmaennchen221
Resolved bug #115 and added test for this explicit behaviour
fb4822f 
Fixed grammar
@Marsmaennchen221 Marsmaennchen221 mentioned this issue Apr 16, 2023
Merged
@Marsmaennchen221 Marsmaennchen221 linked a pull request Apr 16, 2023 that will close this issue
fix: table.keep_only_columns now maps column names to correct data #194
Merged
lars-reimann added a commit that referenced this issue Apr 16, 2023
@Marsmaennchen221 @lars-reimann @megalinter-bot
fix: table.keep_only_columns now maps column names to correct data (#…
459ab75 
…194)

Closes #115 .

### Summary of Changes

Fixed `table.keep_only_columns` to rearrange the column names correctly
Fixed grammar in two docs

---------

Co-authored-by: Lars Reimann <mail@larsreimann.com>
Co-authored-by: megalinter-bot <129584137+megalinter-bot@users.noreply.github.com>
lars-reimann pushed a commit that referenced this issue Apr 21, 2023
@semantic-release-bot
chore(release): 0.11.0 [skip ci]
9509d3d 
## [0.11.0](v0.10.0...v0.11.0) (2023-04-21)

### Features

* `OneHotEncoder.inverse_transform` now maintains the column order from the original table ([#195](#195)) ([3ec0041](3ec0041)), closes [#109](#109) [#109](#109)
* add `plot_` prefix back to plotting methods ([#212](#212)) ([e50c3b0](e50c3b0)), closes [#211](#211)
* adjust `Column`, `Schema` and `Table` to changes in `Row` ([#216](#216)) ([ca3eebb](ca3eebb))
* back `Row` by a `polars.DataFrame` ([#214](#214)) ([62ca34d](62ca34d)), closes [#196](#196) [#149](#149)
* clean up `Row` class ([#215](#215)) ([b12fc68](b12fc68))
* convert between `Row` and `dict` ([#206](#206)) ([e98b653](e98b653)), closes [#204](#204)
* convert between a `dict` and a `Table` ([#198](#198)) ([2a5089e](2a5089e)), closes [#197](#197)
* create column types for `polars` data types ([#208](#208)) ([e18b362](e18b362)), closes [#196](#196)
* dataframe interchange protocol ([#200](#200)) ([bea976a](bea976a)), closes [#199](#199)
* move existing ML solutions into `safeds.ml.classical` package ([#213](#213)) ([655f07f](655f07f)), closes [#210](#210)

### Bug Fixes

* `table.keep_only_columns` now maps column names to correct data ([#194](#194)) ([459ab75](459ab75)), closes [#115](#115)
* typo in type hint ([#184](#184)) ([e79727d](e79727d)), closes [#180](#180)
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Marsmaennchen221 Marsmaennchen221

Labels
bug 🪲 Something isn't working released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: table.keep_only_columns now maps column names to correct data Safe-DS/Library
2 participants
@lars-reimann @Marsmaennchen221