fix: table.keep_only_columns now maps column names to correct data
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed grammar
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## main #194 +/- ##
==========================================
- Coverage 93.89% 93.88% -0.01%
==========================================
Files 42 42
Lines 1457 1455 -2
==========================================
- Hits 1368 1366 -2
Misses 89 89
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lars-reimann
requested changes
Apr 16, 2023
There was a problem hiding this comment.
The title of the PR should also be changed, so a good changelog entry can be created:
- It's not necessary to link to the issue in the title, that's what the
Closes #115is for. - The title should be something that a user can understand
- It's not necessary to point out in the title that tests were added that reproduce the bug. That is implied.
It could be something like "fix: table.keep_only_columns now maps column names to correct data".
tests/safeds/data/tabular/containers/_table/test_keep_only_columns.py
Outdated
Show resolved
Hide resolved
tests/safeds/data/tabular/containers/_table/test_keep_only_columns.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Lars Reimann <mail@larsreimann.com>
Marsmaennchen221
changed the title
table.keep_only_columns now maps column names to correct data
lars-reimann
force-pushed
the
115-tablekeep_only_columns-maps-column-names-to-wrong-data
branch
from
33b8966
to
aabc109
Compare
lars-reimann
force-pushed
the
115-tablekeep_only_columns-maps-column-names-to-wrong-data
branch
from
aabc109
to
2ae3c0d
Compare
lars-reimann
deleted the
115-tablekeep_only_columns-maps-column-names-to-wrong-data
branch
lars-reimann
pushed a commit
that referenced
this pull request
Apr 21, 2023
## [0.11.0](v0.10.0...v0.11.0) (2023-04-21) ### Features * `OneHotEncoder.inverse_transform` now maintains the column order from the original table ([#195](#195)) ([3ec0041](3ec0041)), closes [#109](#109) [#109](#109) * add `plot_` prefix back to plotting methods ([#212](#212)) ([e50c3b0](e50c3b0)), closes [#211](#211) * adjust `Column`, `Schema` and `Table` to changes in `Row` ([#216](#216)) ([ca3eebb](ca3eebb)) * back `Row` by a `polars.DataFrame` ([#214](#214)) ([62ca34d](62ca34d)), closes [#196](#196) [#149](#149) * clean up `Row` class ([#215](#215)) ([b12fc68](b12fc68)) * convert between `Row` and `dict` ([#206](#206)) ([e98b653](e98b653)), closes [#204](#204) * convert between a `dict` and a `Table` ([#198](#198)) ([2a5089e](2a5089e)), closes [#197](#197) * create column types for `polars` data types ([#208](#208)) ([e18b362](e18b362)), closes [#196](#196) * dataframe interchange protocol ([#200](#200)) ([bea976a](bea976a)), closes [#199](#199) * move existing ML solutions into `safeds.ml.classical` package ([#213](#213)) ([655f07f](655f07f)), closes [#210](#210) ### Bug Fixes * `table.keep_only_columns` now maps column names to correct data ([#194](#194)) ([459ab75](459ab75)), closes [#115](#115) * typo in type hint ([#184](#184)) ([e79727d](e79727d)), closes [#180](#180)
|
🎉 This PR is included in version 0.11.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #115 .
Summary of Changes
Fixed
table.keep_only_columnsto rearrange the column names correctlyFixed grammar in two docs