Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for instances in signals and sample EDR signals #4

Merged

Conversation

shubham1413
Copy link
Contributor

Fixed review comments
Enhanced qualityOfSignals to support array of securityContexts
Added new test signal with instance data

@shubham1413 shubham1413 changed the title Feature add instance support Add support for instances in signals and sample EDR signals Mar 10, 2023
Copy link
Contributor

@shuvasafesecurity shuvasafesecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the comment in nodejs/src/bin/generateSampleSignals.ts

@shuvasafesecurity shuvasafesecurity merged commit d4b2977 into Safe-Security:main Mar 10, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants