Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to final round for PEGS #63

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Switch to final round for PEGS #63

merged 4 commits into from
Aug 7, 2024

Conversation

jaymedina
Copy link
Contributor

@jaymedina jaymedina commented Jul 29, 2024

Caution

Not to be merged until the final round begins on August 6th

  1. This PR updates the PEGS dag switching it to the final round profile on nf-synapse-challenge: https://github.com/Sage-Bionetworks-Workflows/nf-synapse-challenge/blob/0b45b1de981eb3e0c854bbbedbd6a570d95dbde2/nextflow.config#L42
  2. This also points to the latest nf-synapse-challenge with these changes

testing

Successful workflow run on test submission:

image

@jaymedina jaymedina marked this pull request as ready for review July 30, 2024 00:09
@jaymedina jaymedina requested a review from a team as a code owner July 30, 2024 00:09
@jaymedina jaymedina requested a review from vpchung July 30, 2024 00:09
dags/pegs-challenge-submission-dag.py Outdated Show resolved Hide resolved
Co-authored-by: Verena Chung <9377970+vpchung@users.noreply.github.com>
@vpchung
Copy link
Contributor

vpchung commented Jul 30, 2024

Can you remind me again, does the "test" profile have the option to not return the scores in the email?

@jaymedina
Copy link
Contributor Author

The test profile does return the scores. We'll have to update it so that send_email param is set to false before merging this, if we don't want that. I'll make another PR over there and update this one after merge.

Copy link

sonarcloud bot commented Jul 31, 2024

@jaymedina jaymedina marked this pull request as draft July 31, 2024 15:22
@jaymedina jaymedina marked this pull request as ready for review August 7, 2024 00:00
@jaymedina jaymedina merged commit 82b1d25 into main Aug 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants