Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop manifest submission error handle #879

Merged
merged 3 commits into from
Aug 29, 2022
Merged

Develop manifest submission error handle #879

merged 3 commits into from
Aug 29, 2022

Conversation

linglp
Copy link
Collaborator

@linglp linglp commented Aug 25, 2022 •
edited
Loading

This issue is related to the issue #874 . Here are the few changes:

  • When a dataset ID is not present in the master file view, I changed it to raise AttributeError instead of ValueError.
  • If user has no permission to upload it to a given folder, I changed the error type from "ValueError" to "PermissionError"
  • I also updated command.py to catch AttributeError being raised
  • In addition, I added "asset view" parameter to swagger UI. Users could update their asset view/file view when using the submit endpoint as well.

@linglp linglp requested a review from GiaJordan August 25, 2022 19:39
@linglp linglp self-assigned this Aug 25, 2022
@GiaJordan
Copy link
Contributor

🚀

@linglp linglp merged commit 93a6789 into develop Aug 29, 2022
@linglp linglp deleted the develop-manifestSubmissionErrorHandle branch August 29, 2022 14:16
@linglp linglp mentioned this pull request Aug 29, 2022
Merged
@GiaJordan GiaJordan mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiaJordan GiaJordan GiaJordan approved these changes

Assignees

@linglp linglp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linglp @GiaJordan