feat(message): remove role of status - FE-5891 #6362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
role of status has been removed this component as Message should not be a live region. If you require a screenreader to read out the Message component, please focus it by using a ref instead. fixes #6013
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 239c253:
|
Parsium
approved these changes
Oct 12, 2023
tomdavies73
approved these changes
Oct 12, 2023
|
PR is currently on hold as QA cannot install an appropriate trial version of JAWS on which to test the fix, as the VM they have set up is a 32-bit machine and the 2023 versions of JAWS require a 64-bit machine. |
sianford
approved these changes
Nov 1, 2023
|
🎉 This PR is included in version 123.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
role of status has been removed from this component as Message should not be a live region. If you
require a screenreader to read out the Message component, please focus it by using a ref instead.
fixes #6013
Proposed behaviour
statusfrom component.Designer Notessection in component docs to reflect new variants.Current behaviour
status.Designer Notessection in component docs does not include new variants.Checklist
d.tsfile added or updated if requiredQA
Additional context
N/A
Testing instructions
Ensure that
With Focusexample ofMessageis read out correctly when opened on:Mac
Windows
Please test using JAWS 2023.2306.38 - June 2023 release or higher