Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(version picker): change order of addon registration and refactor version selector #6706

Merged
merged 2 commits into from
Apr 30, 2024
Merged

chore(version picker): change order of addon registration and refactor version selector #6706

merged 2 commits into from
Apr 30, 2024

Conversation

nineteen88
Copy link
Contributor

Proposed behaviour

  • resolve issue with addon registration so that version selector shows
  • refactor the version selector code to tidy it up a bit

Current behaviour

  • version selector is no longer showing

Checklist

  • Commits follow our style guide

@nineteen88 nineteen88 requested a review from a team as a code owner April 30, 2024 10:27
@nineteen88 nineteen88 merged commit 978f51c into master Apr 30, 2024
21 checks passed
@nineteen88 nineteen88 deleted the FE-6416-fix-missing-version-selector branch April 30, 2024 10:57
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 133.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edleeks87 edleeks87 edleeks87 approved these changes

@tomdavies73 tomdavies73 tomdavies73 approved these changes

Assignees
No one assigned
Labels
No QA Required No UX QA Required Passed Review released Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nineteen88 @carbonci @edleeks87 @tomdavies73