add additional locale support to Carbon #6731
Conversation
src/locales/en-gb.ts
Outdated
| @@ -229,3 +229,4 @@ const enGB: Locale = { | |||
| }; | |||
|
|
|||
| export default enGB; | |||
| export { enGB }; | |||
There was a problem hiding this comment.
suggestion: lets just make the breaking change an update the default export in the index and remove this
There was a problem hiding this comment.
Goof stuff @tomdavies73 I think we should make the breaking change I mention below as part of this PR, I also think we should tweak the commit message slightly (I've pinged you on slack about that). I think the rest of it looks fine, but perhaps we have a chat in office on Thursday with Will as well and iron out anything else we think needs to
docs/i18n.mdx
Outdated
| switch: { | ||
| on: () => "sur", | ||
| off: () => "de", | ||
| locale: () => "eo-EO", |
There was a problem hiding this comment.
suggestion: believe for Esperanto it would just be eo
As there is no regional option? Nice flex though. Just not sure it's the ideal example, but shouldn't cause any problems.
There was a problem hiding this comment.
suggstion: add caveat that we only officially support enGB locale
We need to stipulate that we don't officially support the other locales and that they're provided as an open source implementation only. We aren't responsible for any mistakes and a PR should be raised for corrections
There was a problem hiding this comment.
suggestion: add info about fall back to enGB
edleeks87
changed the title
tomdavies73
force-pushed
the
FE-6429
branch
3 times, most recently
from
568c4be
to
4297940
Compare
tomdavies73
changed the title
tomdavies73
added
Passed Review
and removed
DO NOT MERGE
Pending Translation Review
Pending Review
labels
docs/i18n.mdx
Outdated
|
|
||
| | Component | Link to translation keys table | | ||
| |-----------------------|-------------------------------------------------------------------------------------------| | ||
| | actions | [Table](https://carbon.sage.com/?path=/docs/pod--docs#translation-keys) | |
There was a problem hiding this comment.
question(non-blocking): why are we using absolute links rather than relative?
BREAKING CHANGE: Changes the named export of the en-gb locale from EnGb to enGB
|
🎉 This PR is included in version 137.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Proposed behaviour
Adds native locale support for
de-DE,en-CA,en-US,es-ES,fr-FRandfr-CA. The only distinction betweenen-CAanden-UScompared toen-GBcurrently is date formatting.de-DE,es-ESandfr-FRare completely new locales.fr-CAhas also been added which inherits the translations provided infr-FRbut some specific locale objects are overridden due to language variation.PLEASE NOTE: Not all translations have been provided, you will find for some locale objects either the
"NO TRANSLATION PROVIDED"string has been passed or the locale objects using string interpolation have been left empty. We have requested these translations, and they are in the process of being translated by the translations team. This PR will not be merged until we have all required translations.Our
i18ndocumentation has also been updated to represent these new changes, and to improve the general quality of the documentation overall.Current behaviour
Currently, only the
en-GBlocale is supported in Carbon.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions