chore(box): convert to tests to rtl (FE-6557) #6756
Conversation
nineteen88
added
Pending Review
No QA Required
No UX QA Required
Squad Front End
box
and removed
box
labels
src/components/box/box.test.tsx
Outdated
| // mock Logger.deprecate so that no console warnings occur while running the tests | ||
| const loggerSpy = jest.spyOn(Logger, "deprecate"); |
There was a problem hiding this comment.
suggestion: what do you think about removing this mock, so any legitimate warnings that the tests throw that need addressing aren't masked?
There was a problem hiding this comment.
I think it's worth trying to mock it for the specific test we want to ignore the console for, yes there's a small chance that specific one will have another legitimate console warning it's not likely a huge issue and removing the mock altogether means we'll have a lot of superfluous console logging polluting the output when we run our tests
There was a problem hiding this comment.
Actually, is there any deprecation warnings we need to mock here?
There was a problem hiding this comment.
I guess that's actually hangover from when we had deprecation warnings on Box. So I'm happy to remove it.
|
🎉 This PR is included in version 137.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Proposed behaviour
Current behaviour
Checklist