fix(character-count): prevent screen reader announcing value when submitting a form #6792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DipperTheDan
force-pushed
the
FE-6054_character-count-aria-live-fix
branch
from
17fb574
to
313ee41
Compare
tomdavies73
reviewed
Jun 25, 2024
Parsium
reviewed
Jun 25, 2024
DipperTheDan
force-pushed
the
FE-6054_character-count-aria-live-fix
branch
2 times, most recently
from
0174d81
to
6483ec9
Compare
Parsium
approved these changes
Jun 25, 2024
tomdavies73
approved these changes
Jun 25, 2024
|
Did a review of this with @tempertemper, all good 👍 |
ZhuoyuJin
approved these changes
Jul 3, 2024
…mitting a form This work fixes a bug whereby a screen reader announces the character count 'You have `n` characters remaining' message after form submission. To address this, we have defaulted aria-live to off until the input is focused where it will then have the value of polite. fixes #6181
DipperTheDan
force-pushed
the
FE-6054_character-count-aria-live-fix
branch
from
6483ec9
to
17ff11f
Compare
|
🎉 This PR is included in version 140.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work fixes a bug whereby a screen reader announces the character count 'You have
ncharacters remaining' message after form submission. To address this, we have defaulted aria-live to off until the input is focused where it will then have the value of polite.fixes #6181
Proposed behaviour
Default aria-live value is
offuntil the input is focused where it will then have the value ofpolite. Once the input is blurred, the aria-live value will be reset tooff.Current behaviour
By default, the aria-live value is always
polite.Checklist
d.tsfile added or updated if requiredQA
Additional context
N/A
Testing instructions
I have created a test story in Form called
Mock form for aria live demo. In this demo you should check:offby default (you can find this value by looking at thedivelement withdata-element="visually-hidden-character-count"). When the input is focused, the aria-live value should change topolite.Savebutton, there should be no update provided regarding the character counts in any of the inputs.