Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(link): update styling of skip link variant - FE-6719 #6885

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

DipperTheDan
Copy link
Contributor

@DipperTheDan DipperTheDan commented Aug 7, 2024

Proposed behaviour

Screenshot 2024-08-13 at 10 48 38

Current behaviour

Screenshot 2024-08-07 at 16 08 20

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

I have removed the styling tests in RTL for the skip link variant. The tests used toHaveStyle assertion with token values and we have come to learn these tests don't really work as they always pass. These styles are better tested in Playwright, which we already had.

Testing instructions

  • SkipLink should match the designs provided on the ticket.
  • There should not be any other styling regressions with Link.

nineteen88
nineteen88 previously approved these changes Aug 8, 2024
tomdavies73
tomdavies73 previously approved these changes Aug 12, 2024
@DipperTheDan DipperTheDan force-pushed the FE-6719_SkipLink-updated-styling branch from ef6df1b to 79e44c9 Compare August 16, 2024 08:43
@DipperTheDan DipperTheDan merged commit aaff424 into master Aug 16, 2024
21 checks passed
@DipperTheDan DipperTheDan deleted the FE-6719_SkipLink-updated-styling branch August 16, 2024 08:59
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 142.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants