This repository has been archived by the owner on Aug 22, 2023. It is now read-only.
feat: enable linting support #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinayakkulkarni
commented
May 17, 2021
vinayakkulkarni
commented
- Enables strong linting support using ESLint
- Add CI workflows to ensure there aren't any lint errors in the code
- Fixes Add a linter #11
|
Hi @vinayakkulkarni, thanks for the PR. It looks very good. As soon as I have time I will check that everything is still working and do the merge. Best Regards, |
|
@Saigesp: Can we take this forward? |
|
@Saigesp: Can you test this? I've tested it, it works from my side. |
|
@Saigesp: any update? |
vinayakkulkarni
force-pushed
the
feat/add-linting-support
branch
from
e7e52ab
to
4850bfe
Compare
|
@Saigesp: any ETA on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.