-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major refactor / rewrite #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big PR with a major refactor / rewrite of the impl which also introduces some breaking API changes.
First of all, the
K1.PrivateKey
/K1.PublicKey
key pair has been removed, in favour of more CryptoKit like APIs splitting the keys up in multiple key pairs:K1.ECDSA.Recoverable.PrivateKey
/K1.ECDSA.Recoverable.PublicKey
K1.ECDSA.NonRecoverable.PrivateKey
/K1.ECDSA.NonRecoverable.PublicKey
K1.Schnorr.PrivateKey
/K1.Schnorr.PublicKey
K1.KeyAgreement.PrivateKey
/K1.KeyAgreement.PublicKey
The ECDSA signing methods now use this format:
signature:for:options
andsignature:forUnhashed:options
The Schnorr validation methods now use this format:
isValidSignature:hashed
andisValidSignature:digest
andisValidSignature:unhashed
The ECDSA validation methods (shared for Recoverable and NonRecoverable) now use this format:
isValidSignature:hashed:options
andisValidSignature:digest:options
andisValidSignature:unhashed:options
Furthermore more Serialization and Deserialization methods have been added to:
Such as
pem
,der
and more.