Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pdf sender margins - avoid barcode intrusion #84

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

AndriyFil
Copy link
Contributor

@AndriyFil AndriyFil commented Feb 12, 2024

Hello, and thanks for contributing to PplMyApi

tldr

There are two main goals in this document, depending on the nature of your PR:

  • description: please tell us about your pr
  • checklist: please review the checklist that is most closly related to your PR

The following sections provide more detail on each.

Improve this document

Please don't hesitate to ask questions for clarification, or to make suggestions (or a pull request) to improve this document.

Description

Hi, I've changed margins for pdf document because of the bug I have
Before:
image

After:
image

Checklist

Please use the checklist that is most closely related to your PR (you only need to use one checklist, and you can skip items that aren't applicable or don't make sense):

Fixing typos

  • Please review the readme advice section before submitting changes

Documentation

  • Please review the readme advice section before submitting changes

Bug Fix

  • All existing unit tests are still passing (if applicable)
  • Add new passing unit tests to cover the code introduced by your PR
  • Update the readme (see readme advice)
  • Update or add any necessary API documentation

New Feature

  • If this is a big feature with breaking changes, consider opening an issue to discuss first. This is completely up to you, but please keep in mind that your pr might not be accepted.
  • Run unit tests to ensure all existing tests are still passing
  • Add new passing unit tests to cover the code introduced by your PR
  • Update the readme (see readme advice)

Thanks for contributing!

Readme advice

Please review this section if you are updating readme documentation.

Code comments

Please add code comments (following the same style as existing comments) to describe any code changes or new code introduced by your pull request.

@Salamek Salamek merged commit 4f55a00 into Salamek:master Feb 12, 2024
1 check passed
@Salamek Salamek mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants